test: do not dump core in external memory limit test · nodejs/node@a8f1517 · GitHub
Skip to content

Commit a8f1517

Browse files
codebyterenodejs-github-bot
authored andcommitted
test: do not dump core in external memory limit test
test-external-memory-reasonable-size makes a child allocate 1.2 GB of external memory so that V8's --external-memory-max-reasonable-size check fires and the process aborts. The abort raises SIGABRT with all of that memory resident, and on hosts that write core files (the SmartOS CI machines in particular) the dump takes longer than the test timeout, so the test has been timing out there since it was added. Run the child under `ulimit -c 0` on POSIX, the same way test-abort-fatal-error and common.childShouldThrowAndAbort() handle their aborting children. Refs: #65589 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65780 Fixes: #64226 Refs: #59146 Refs: #54534 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 29d39e1 commit a8f1517

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

‎test/parallel/test-external-memory-reasonable-size.js‎

Lines changed: 11 additions & 10 deletions

0 commit comments

Comments
 (0)