url: align URLPatternInit dictionary conversion with WebIDL · nodejs/node@a82cc70 · GitHub
Skip to content

Commit a82cc70

Browse files
piyushrajyadavaduh95
authored andcommitted
url: align URLPatternInit dictionary conversion with WebIDL
Read URLPatternInit dictionary members in lexicographical order so getters and proxy traps observe the access sequence required by WebIDL. Use sparse dictionary template values so URLPatternResult inputs only expose members present after WebIDL conversion. Fixes: #64780 Signed-off-by: piyushrajyadav <piyushyadavrajyadav@gmail.com> PR-URL: #65498 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent ec96f8d commit a82cc70

2 files changed

Lines changed: 58 additions & 29 deletions

File tree

‎src/node_url_pattern.cc‎

Lines changed: 18 additions & 29 deletions

‎test/parallel/test-urlpattern.js‎

Lines changed: 40 additions & 0 deletions

0 commit comments

Comments
 (0)