stream: fix performance regression

mscdex · ronag · commit a5ba28dda2c2 · 2021-07-08T08:15:25.000+02:00
PR-URL: #39254 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/streams/duplex.js b/lib/internal/streams/duplex.js
@@ -56,19 +56,23 @@ function Duplex(options) {
   Readable.call(this, options);
   Writable.call(this, options);
 
-  this.allowHalfOpen = options?.allowHalfOpen !== false;
+  if (options) {
+    this.allowHalfOpen = options.allowHalfOpen !== false;
 
-  if (options?.readable === false) {
-    this._readableState.readable = false;
-    this._readableState.ended = true;
-    this._readableState.endEmitted = true;
-  }
+    if (options.readable === false) {
+      this._readableState.readable = false;
+      this._readableState.ended = true;
+      this._readableState.endEmitted = true;
+    }
 
-  if (options?.writable === false) {
-    this._writableState.writable = false;
-    this._writableState.ending = true;
-    this._writableState.ended = true;
-    this._writableState.finished = true;
+    if (options.writable === false) {
+      this._writableState.writable = false;
+      this._writableState.ending = true;
+      this._writableState.ended = true;
+      this._writableState.finished = true;
+    }
+  } else {
+    this.allowHalfOpen = true;
   }
 }
 
