test_runner: nix dead reporter code

vassudanagunta · aduh95 · commit a5a4c3eb4448 · 2026-01-20T14:36:00.000+01:00
reporter/utils.js formatTestReport: 1. hasChildren and showErrorDetails are never both true in existing calls. 2. Thus if hasChildren is true, showErrorDetails is false. 3. So `|| data.details?.error?.failureType === 'subtestsFailed'` is irrelevant. 4. And `\n${error}` never occurs. Even though all tests pass after this commit, what if future reporter code might make calls where both hasChildren and showErrorDetails are true? I will address this in the last commit of this PR. Trust me for now. PR-URL: #59700 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
diff --git a/lib/internal/test_runner/reporter/spec.js b/lib/internal/test_runner/reporter/spec.js
@@ -53,7 +53,7 @@ class SpecReporter extends Transform {
     }
 
     this.#failedTests = []; // Clean up the failed tests
-    return ArrayPrototypeJoin(results, '\n'); ;
+    return ArrayPrototypeJoin(results, '\n');
   }
   #handleTestReportEvent(type, data) {
     const subtest = ArrayPrototypeShift(this.#stack); // This is the matching `test:start` event
@@ -71,13 +71,8 @@ class SpecReporter extends Transform {
       ArrayPrototypeUnshift(this.#reported, msg);
       prefix += `${indent(msg.nesting)}${reporterUnicodeSymbolMap['arrow:right']}${msg.name}\n`;
     }
-    let hasChildren = false;
-    if (this.#reported[0] && this.#reported[0].nesting === data.nesting && this.#reported[0].name === data.name) {
-      ArrayPrototypeShift(this.#reported);
-      hasChildren = true;
-    }
     const indentation = indent(data.nesting);
-    return `${formatTestReport(type, data, prefix, indentation, hasChildren, false)}\n`;
+    return `${formatTestReport(type, data, false, prefix, indentation)}\n`;
   }
   #handleEvent({ type, data }) {
     switch (type) {
diff --git a/lib/internal/test_runner/reporter/utils.js b/lib/internal/test_runner/reporter/utils.js
@@ -58,7 +58,6 @@ function indent(nesting) {
 }
 
 function formatError(error, indent) {
-  if (!error) return '';
   const err = error.code === 'ERR_TEST_FAILURE' ? error.cause : error;
   const message = ArrayPrototypeJoin(
     RegExpPrototypeSymbolSplit(
@@ -68,7 +67,7 @@ function formatError(error, indent) {
   return `\n${indent}  ${message}\n`;
 }
 
-function formatTestReport(type, data, prefix = '', indent = '', hasChildren = false, showErrorDetails = true) {
+function formatTestReport(type, data, showErrorDetails = true, prefix = '', indent = '') {
   let color = reporterColorMap[type] ?? colors.white;
   let symbol = reporterUnicodeSymbolMap[type] ?? ' ';
   const { skip, todo, expectFailure } = data;
@@ -83,10 +82,7 @@ function formatTestReport(type, data, prefix = '', indent = '', hasChildren = fa
     title += ` # EXPECTED FAILURE`;
   }
 
-  const error = showErrorDetails ? formatError(data.details?.error, indent) : '';
-  const err = hasChildren ?
-    (!error || data.details?.error?.failureType === 'subtestsFailed' ? '' : `\n${error}`) :
-    error;
+  const err = showErrorDetails && data.details?.error ? formatError(data.details.error, indent) : '';
 
   if (skip !== undefined) {
     color = colors.gray;

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class SpecReporter extends Transform {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`this.#failedTests = []; // Clean up the failed tests`
`56`		`- return ArrayPrototypeJoin(results, '\n'); ;`
	`56`	`+ return ArrayPrototypeJoin(results, '\n');`
`57`	`57`	`}`
`58`	`58`	`#handleTestReportEvent(type, data) {`
`59`	`59`	const subtest = ArrayPrototypeShift(this.#stack); // This is the matching `test:start` event
`@@ -71,13 +71,8 @@ class SpecReporter extends Transform {`
`71`	`71`	`ArrayPrototypeUnshift(this.#reported, msg);`
`72`	`72`	prefix += `${indent(msg.nesting)}${reporterUnicodeSymbolMap['arrow:right']}${msg.name}\n`;
`73`	`73`	`}`
`74`		`- let hasChildren = false;`
`75`		`- if (this.#reported[0] && this.#reported[0].nesting === data.nesting && this.#reported[0].name === data.name) {`
`76`		`- ArrayPrototypeShift(this.#reported);`
`77`		`- hasChildren = true;`
`78`		`- }`
`79`	`74`	`const indentation = indent(data.nesting);`
`80`		- return `${formatTestReport(type, data, prefix, indentation, hasChildren, false)}\n`;
	`75`	+ return `${formatTestReport(type, data, false, prefix, indentation)}\n`;
`81`	`76`	`}`
`82`	`77`	`#handleEvent({ type, data }) {`
`83`	`78`	`switch (type) {`