stream: do not defer construction by one microtick

mcollina · targos · commit a48c9ca0dbe3 · 2024-03-08T14:36:29.000+01:00
Fixes: #51993 PR-URL: #52005 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -291,7 +291,7 @@ function constructNT(stream) {
     } else if (err) {
       errorOrDestroy(stream, err, true);
     } else {
-      process.nextTick(emitConstructNT, stream);
+      stream.emit(kConstruct);
     }
   }
 
@@ -304,10 +304,6 @@ function constructNT(stream) {
   }
 }
 
-function emitConstructNT(stream) {
-  stream.emit(kConstruct);
-}
-
 function isRequest(stream) {
   return stream?.setHeader && typeof stream.abort === 'function';
 }
diff --git a/test/parallel/test-fs-writestream-open-write.js b/test/parallel/test-fs-writestream-open-write.js
@@ -0,0 +1,28 @@
+'use strict';
+
+const common = require('../common');
+const tmpdir = require('../common/tmpdir');
+const { strictEqual } = require('assert');
+const fs = require('fs');
+
+// Regression test for https://github.com/nodejs/node/issues/51993
+
+tmpdir.refresh();
+
+const file = tmpdir.resolve('test-fs-writestream-open-write.txt');
+
+const w = fs.createWriteStream(file);
+
+w.on('open', common.mustCall(() => {
+  w.write('hello');
+
+  process.nextTick(() => {
+    w.write('world');
+    w.end();
+  });
+}));
+
+w.on('close', common.mustCall(() => {
+  strictEqual(fs.readFileSync(file, 'utf8'), 'helloworld');
+  fs.unlinkSync(file);
+}));

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ function constructNT(stream) {`
`291`	`291`	`} else if (err) {`
`292`	`292`	`errorOrDestroy(stream, err, true);`
`293`	`293`	`} else {`
`294`		`- process.nextTick(emitConstructNT, stream);`
	`294`	`+ stream.emit(kConstruct);`
`295`	`295`	`}`
`296`	`296`	`}`
`297`	`297`
`@@ -304,10 +304,6 @@ function constructNT(stream) {`
`304`	`304`	`}`
`305`	`305`	`}`
`306`	`306`
`307`		`-function emitConstructNT(stream) {`
`308`		`- stream.emit(kConstruct);`
`309`		`-}`
`310`		`-`
`311`	`307`	`function isRequest(stream) {`
`312`	`308`	`return stream?.setHeader && typeof stream.abort === 'function';`
`313`	`309`	`}`