inspector: perform DNS lookup for host · nodejs/node@a45792a · GitHub
Skip to content

Commit a45792a

Browse files
Eugene Ostroukhovaddaleax
authored andcommitted
inspector: perform DNS lookup for host
PR-URL: #13478 Fixes: #13477 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 820b011 commit a45792a

7 files changed

Lines changed: 343 additions & 163 deletions

src/inspector_agent.cc

Lines changed: 1 addition & 7 deletions

src/inspector_io.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ void InspectorIo::ThreadMain() {
313313
uv_sem_post(&thread_start_sem_);
314314
return;
315315
}
316-
port_ = server.port(); // Safe, main thread is waiting on semaphore.
316+
port_ = server.Port(); // Safe, main thread is waiting on semaphore.
317317
if (!wait_for_connect_) {
318318
uv_sem_post(&thread_start_sem_);
319319
}

src/inspector_io.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ class StringView;
2828
namespace node {
2929
namespace inspector {
3030

31+
std::string FormatWsAddress(const std::string& host, int port,
32+
const std::string& target_id,
33+
bool include_protocol);
34+
3135
class InspectorIoDelegate;
3236

3337
enum class InspectorAction {

src/inspector_socket.h

Lines changed: 1 addition & 0 deletions

0 commit comments

Comments
 (0)