tools: forbid template literals in assert.throws

targos · MylesBorins · commit 9f13b5f7d5d1 · 2017-01-31T20:04:31.000-05:00
Extend the assert-throws-arguments custom ESLint rule to also check for the use of template literals as a second argument to assert.throws. PR-URL: #10301 Ref: #10282 (comment) Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Italo A. Casas <me@italoacasas.com>
diff --git a/tools/eslint-rules/assert-throws-arguments.js b/tools/eslint-rules/assert-throws-arguments.js
@@ -21,7 +21,8 @@ function checkThrowsArguments(context, node) {
       });
     } else if (args.length > 1) {
       const error = args[1];
-      if (error.type === 'Literal' && typeof error.value === 'string') {
+      if (error.type === 'Literal' && typeof error.value === 'string' ||
+          error.type === 'TemplateLiteral') {
         context.report({
           message: 'Unexpected string as second argument',
           node: error
