test: check arg type for dnsPromises.resolve

Masashi Hirano · targos · commit 9d85a059b79c · 2018-08-11T17:33:42.000+02:00
PR-URL: #22000 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/test/parallel/test-dns.js b/test/parallel/test-dns.js
@@ -135,14 +135,31 @@ assert.deepStrictEqual(dns.getServers(), portsExpected);
 dns.setServers([]);
 assert.deepStrictEqual(dns.getServers(), []);
 
-common.expectsError(() => {
-  dns.resolve('example.com', [], common.mustNotCall());
-}, {
-  code: 'ERR_INVALID_ARG_TYPE',
-  type: TypeError,
-  message: 'The "rrtype" argument must be of type string. ' +
-           'Received type object'
-});
+{
+  const errObj = {
+    code: 'ERR_INVALID_ARG_TYPE',
+    type: TypeError,
+    message: 'The "rrtype" argument must be of type string. ' +
+             'Received type object'
+  };
+  common.expectsError(() => {
+    dns.resolve('example.com', [], common.mustNotCall());
+  }, errObj);
+  common.expectsError(() => {
+    dnsPromises.resolve('example.com', []);
+  }, errObj);
+}
+{
+  const errObj = {
+    code: 'ERR_INVALID_ARG_TYPE',
+    type: TypeError,
+    message: 'The "name" argument must be of type string. ' +
+             'Received type undefined'
+  };
+  common.expectsError(() => {
+    dnsPromises.resolve();
+  }, errObj);
+}
 
 // dns.lookup should accept only falsey and string values
 {
