ffi: accept pointer BigInts in multi-argument fast calls · nodejs/node@9c282c4 · GitHub
Skip to content

Commit 9c282c4

Browse files
trivikraduh95
authored andcommitted
ffi: accept pointer BigInts in multi-argument fast calls
convertPointerArg ended with an unconditional getRawPointer call for buffer and arraybuffer types, rejecting BigInt addresses that the single-argument fast path and ToFFIArgument both accept. Drop the fallback; hasPointerMemoryArg already converts memory-backed values, and null, undefined, and strings are handled earlier. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5 PR-URL: #64964 Fixes: #64963 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent f0140d7 commit 9c282c4

2 files changed

Lines changed: 35 additions & 3 deletions

File tree

lib/internal/ffi/fast-api.js

Lines changed: 2 additions & 3 deletions

test/ffi/test-ffi-fast-buffer.js

Lines changed: 33 additions & 0 deletions

0 commit comments

Comments
 (0)