src: fix implementation of PropertySetterCallback

isheludko · aduh95 · commit 9bde9b254dbf · 2024-07-16T12:01:16.000+02:00
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: #53576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -614,7 +614,6 @@ Intercepted ContextifyContext::PropertySetterCallback(
     // property
     if (desc_obj->HasOwnProperty(context, env->get_string()).FromMaybe(false) ||
         desc_obj->HasOwnProperty(context, env->set_string()).FromMaybe(false)) {
-      args.GetReturnValue().Set(value);
       return Intercepted::kYes;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,6 @@ Intercepted ContextifyContext::PropertySetterCallback(`
`614`	`614`	`// property`
`615`	`615`	`if (desc_obj->HasOwnProperty(context, env->get_string()).FromMaybe(false) \|\|`
`616`	`616`	`desc_obj->HasOwnProperty(context, env->set_string()).FromMaybe(false)) {`
`617`		`- args.GetReturnValue().Set(value);`
`618`	`617`	`return Intercepted::kYes;`
`619`	`618`	`}`
`620`	`619`	`}`