File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -151,7 +151,7 @@ to review changes that are split across multiple commits.
151151
152152``` bash
153153git add my/changed/files
154- git commit
154+ git commit -s
155155```
156156
157157Multiple commits often get squashed when they are landed. See the
@@ -206,6 +206,9 @@ A good commit message should describe what changed and why.
206206 This rule does not apply to dependency updates (e.g. cherry-picks), release
207207 commits, or backport commits.
208208
209+ [ ` git commit -s ` ] [ git commit -s ] (with lowercase ` s ` ) adds a
210+ ` Signed-off-by ` trailer at the end of the commit log message.
211+
209212Sample final commit message after landing:
210213
211214``` text
@@ -312,7 +315,7 @@ GitHub will automatically update the pull request.
312315
313316``` bash
314317git add my/changed/files
315- git commit
318+ git commit -s
316319git push origin my-branch
317320```
318321
@@ -617,6 +620,7 @@ More than one subsystem may be valid for any particular issue or pull request.
617620[ approved ] : #getting-approvals-for-your-pull-request
618621[ benchmark results ] : writing-and-running-benchmarks.md
619622[ collaborator guide ] : collaborator-guide.md
623+ [ git commit -s ] : https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s
620624[ guide for writing tests in Node.js ] : writing-tests.md
621625[ hiding-a-comment ] : https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
622626[ https://ci.nodejs.org/ ] : https://ci.nodejs.org/
You can’t perform that action at this time.
0 commit comments