src: release context frame in AsyncWrap::EmitDestroy

Flarna · aduh95 · commit 975dafbe3b71 · 2026-03-10T14:48:51.000+01:00
Release the async context frame in AsyncWrap::EmitDestroy to allow gc to collect it. This is in special relevant for reused resources like HTTPParser otherwise they might keep ALS stores alive. PR-URL: #61995 Fixes: #61882 Refs: #48528 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
diff --git a/src/async_wrap.cc b/src/async_wrap.cc
@@ -25,6 +25,9 @@
 #include "env-inl.h"
 #include "node_errors.h"
 #include "node_external_reference.h"
+#ifdef DEBUG
+#include <node_process-inl.h>
+#endif
 #include "tracing/traced_value.h"
 #include "util-inl.h"
 
@@ -333,9 +336,12 @@ void AsyncWrap::EmitDestroy(bool from_gc) {
   // Ensure no double destroy is emitted via AsyncReset().
   async_id_ = kInvalidAsyncId;
 
-  if (!persistent().IsEmpty() && !from_gc) {
-    HandleScope handle_scope(env()->isolate());
-    USE(object()->Set(env()->context(), env()->resource_symbol(), object()));
+  if (!from_gc) {
+    if (!persistent().IsEmpty()) {
+      HandleScope handle_scope(env()->isolate());
+      USE(object()->Set(env()->context(), env()->resource_symbol(), object()));
+    }
+    context_frame_.Reset();
   }
 }
 
@@ -659,6 +665,14 @@ MaybeLocal<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
                                           Local<Value>* argv) {
   EmitTraceEventBefore();
 
+#ifdef DEBUG
+  if (context_frame_.IsEmpty()) {
+    ProcessEmitWarning(env(),
+                       "MakeCallback() called without context_frame, "
+                       "likely use after destroy of AsyncWrap.");
+  }
+#endif
+
   ProviderType provider = provider_type();
   async_context context { get_async_id(), get_trigger_async_id() };
   MaybeLocal<Value> ret =
diff --git a/test/parallel/test-async-local-storage-http-parser-leak.js b/test/parallel/test-async-local-storage-http-parser-leak.js
@@ -0,0 +1,29 @@
+// Flags: --expose-gc
+'use strict';
+
+const common = require('../common');
+const { onGC } = require('../common/gc');
+const assert = require('node:assert');
+const { AsyncLocalStorage } = require('node:async_hooks');
+const { freeParser, parsers, HTTPParser } = require('_http_common');
+
+let storeGCed = false;
+
+const als = new AsyncLocalStorage();
+
+function test() {
+  const store = {};
+  onGC(store, { ongc: common.mustCall(() => { storeGCed = true; }) });
+  let parser;
+  als.run(store, common.mustCall(() => {
+    parser = parsers.alloc();
+    parser.initialize(HTTPParser.RESPONSE, {});
+  }));
+  freeParser(parser);
+}
+
+test();
+global.gc();
+setImmediate(common.mustCall(() => {
+  assert.ok(storeGCed);
+}));
