src: use RAII in setgroups implementation

addaleax · BridgeAR · commit 95ee3b55d34d · 2019-06-17T19:49:53.000+02:00
Prefer `MaybeStackBuffer` over manual memory management. PR-URL: #28022 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/src/node_credentials.cc b/src/node_credentials.cc
@@ -307,14 +307,13 @@ static void SetGroups(const FunctionCallbackInfo<Value>& args) {
 
   Local<Array> groups_list = args[0].As<Array>();
   size_t size = groups_list->Length();
-  gid_t* groups = new gid_t[size];
+  MaybeStackBuffer<gid_t, 64> groups(size);
 
   for (size_t i = 0; i < size; i++) {
     gid_t gid = gid_by_name(
         env->isolate(), groups_list->Get(env->context(), i).ToLocalChecked());
 
     if (gid == gid_not_found) {
-      delete[] groups;
       // Tells JS to throw ERR_INVALID_CREDENTIAL
       args.GetReturnValue().Set(static_cast<uint32_t>(i + 1));
       return;
@@ -323,8 +322,7 @@ static void SetGroups(const FunctionCallbackInfo<Value>& args) {
     groups[i] = gid;
   }
 
-  int rc = setgroups(size, groups);
-  delete[] groups;
+  int rc = setgroups(size, *groups);
 
   if (rc == -1) return env->ThrowErrnoException(errno, "setgroups");
 
