sea: split sea binary manipulation code

joyeecheung · aduh95 · commit 957292e23390 · 2026-01-25T00:07:49.000+01:00
Split the sea binary manipulation code to a seperate file so that adding more low-level binary manipulation code doesn't clobber the higher-level code. PR-URL: #61167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/node.gyp b/node.gyp
@@ -142,6 +142,7 @@
       'src/node_report_module.cc',
       'src/node_report_utils.cc',
       'src/node_sea.cc',
+      'src/node_sea_bin.cc',
       'src/node_serdes.cc',
       'src/node_shadow_realm.cc',
       'src/node_snapshotable.cc',
diff --git a/src/node_sea.cc b/src/node_sea.cc
@@ -14,15 +14,6 @@
 #include "simdjson.h"
 #include "util-inl.h"
 
-// The POSTJECT_SENTINEL_FUSE macro is a string of random characters selected by
-// the Node.js project that is present only once in the entire binary. It is
-// used by the postject_has_resource() function to efficiently detect if a
-// resource has been injected. See
-// https://github.com/nodejs/postject/blob/35343439cac8c488f2596d7c4c1dddfec1fddcae/postject-api.h#L42-L45.
-#define POSTJECT_SENTINEL_FUSE "NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2"
-#include "postject-api.h"
-#undef POSTJECT_SENTINEL_FUSE
-
 #include <memory>
 #include <string_view>
 #include <tuple>
@@ -233,33 +224,6 @@ SeaResource SeaDeserializer::Read() {
           exec_argv};
 }
 
-std::string_view FindSingleExecutableBlob() {
-#if !defined(DISABLE_SINGLE_EXECUTABLE_APPLICATION)
-  CHECK(IsSingleExecutable());
-  static const std::string_view result = []() -> std::string_view {
-    size_t size;
-#ifdef __APPLE__
-    postject_options options;
-    postject_options_init(&options);
-    options.macho_segment_name = "NODE_SEA";
-    const char* blob = static_cast<const char*>(
-        postject_find_resource("NODE_SEA_BLOB", &size, &options));
-#else
-    const char* blob = static_cast<const char*>(
-        postject_find_resource("NODE_SEA_BLOB", &size, nullptr));
-#endif
-    return {blob, size};
-  }();
-  per_process::Debug(DebugCategory::SEA,
-                     "Found SEA blob %p, size=%zu\n",
-                     result.data(),
-                     result.size());
-  return result;
-#else
-  UNREACHABLE();
-#endif  // !defined(DISABLE_SINGLE_EXECUTABLE_APPLICATION)
-}
-
 }  // anonymous namespace
 
 bool SeaResource::use_snapshot() const {
@@ -283,9 +247,6 @@ SeaResource FindSingleExecutableResource() {
   return sea_resource;
 }
 
-bool IsSingleExecutable() {
-  return postject_has_resource();
-}
 
 void IsSea(const FunctionCallbackInfo<Value>& args) {
   args.GetReturnValue().Set(IsSingleExecutable());
diff --git a/src/node_sea.h b/src/node_sea.h
@@ -54,6 +54,7 @@ struct SeaResource {
 };
 
 bool IsSingleExecutable();
+std::string_view FindSingleExecutableBlob();
 SeaResource FindSingleExecutableResource();
 std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv);
 node::ExitCode BuildSingleExecutableBlob(
diff --git a/src/node_sea_bin.cc b/src/node_sea_bin.cc
@@ -0,0 +1,66 @@
+#include "node_sea.h"
+
+#ifdef HAVE_LIEF
+#include "LIEF/LIEF.hpp"
+#endif  // HAVE_LIEF
+
+#include "debug_utils-inl.h"
+#include "env-inl.h"
+#include "util-inl.h"
+
+#include <algorithm>
+#include <codecvt>
+#include <locale>
+#include <memory>
+#include <vector>
+#include <string>
+#include <iostream>
+#include <fstream>
+#include <sstream>
+#include <string_view>
+
+// The POSTJECT_SENTINEL_FUSE macro is a string of random characters selected by
+// the Node.js project that is present only once in the entire binary. It is
+// used by the postject_has_resource() function to efficiently detect if a
+// resource has been injected. See
+// https://github.com/nodejs/postject/blob/35343439cac8c488f2596d7c4c1dddfec1fddcae/postject-api.h#L42-L45.
+#define POSTJECT_SENTINEL_FUSE "NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2"
+#include "postject-api.h"
+#undef POSTJECT_SENTINEL_FUSE
+
+namespace node {
+namespace sea {
+
+std::string_view FindSingleExecutableBlob() {
+#if !defined(DISABLE_SINGLE_EXECUTABLE_APPLICATION)
+  CHECK(IsSingleExecutable());
+  static const std::string_view result = []() -> std::string_view {
+    size_t size;
+#ifdef __APPLE__
+    postject_options options;
+    postject_options_init(&options);
+    options.macho_segment_name = "NODE_SEA";
+    const char* blob = static_cast<const char*>(
+        postject_find_resource("NODE_SEA_BLOB", &size, &options));
+#else
+    const char* blob = static_cast<const char*>(
+        postject_find_resource("NODE_SEA_BLOB", &size, nullptr));
+#endif
+    return {blob, size};
+  }();
+  per_process::Debug(DebugCategory::SEA,
+                     "Found SEA blob %p, size=%zu\n",
+                     result.data(),
+                     result.size());
+  return result;
+#else
+  UNREACHABLE();
+#endif  // !defined(DISABLE_SINGLE_EXECUTABLE_APPLICATION)
+}
+
+bool IsSingleExecutable() {
+  return postject_has_resource();
+}
+
+}  // namespace sea
+}  // namespace node
