assert: resolve TODO and rename function

aduh95 · web-flow · commit 91f035e5975a · 2025-08-14T09:51:13.000Z
PR-URL: #59451 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/assert.js b/lib/assert.js
@@ -83,7 +83,7 @@ function lazyLoadComparison() {
 // AssertionError's when particular conditions are not met. The
 // assert module must conform to the following interface.
 
-const assert = module.exports = ok;
+module.exports = assert;
 
 const NO_EXCEPTION_SENTINEL = {};
 
@@ -186,8 +186,8 @@ assert.AssertionError = AssertionError;
  * @param {...any} args
  * @returns {void}
  */
-function ok(...args) {
-  innerOk(ok, args.length, ...args);
+function assert(...args) {
+  innerOk(assert, args.length, ...args);
 }
 
 /**
@@ -890,10 +890,8 @@ function strict(...args) {
   innerOk(strict, args.length, ...args);
 }
 
-// TODO(aduh95): take `ok` from `Assert.prototype` instead of a self-ref in a next major.
-assert.ok = assert;
 ArrayPrototypeForEach([
-  'fail', 'equal', 'notEqual', 'deepEqual', 'notDeepEqual',
+  'ok', 'fail', 'equal', 'notEqual', 'deepEqual', 'notDeepEqual',
   'deepStrictEqual', 'notDeepStrictEqual', 'strictEqual',
   'notStrictEqual', 'partialDeepStrictEqual', 'match', 'doesNotMatch',
   'throws', 'rejects', 'doesNotThrow', 'doesNotReject', 'ifError',
diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
@@ -58,7 +58,7 @@ assert.strictEqual(
       code: 'ENOENT',
       name: 'Error',
       message: /^ENOENT: no such file or directory, access/,
-      stack: /at async ok\.rejects/
+      stack: /at async assert\.rejects/
     }
   ).then(common.mustCall());
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ assert.strictEqual(`
`58`	`58`	`code: 'ENOENT',`
`59`	`59`	`name: 'Error',`
`60`	`60`	`message: /^ENOENT: no such file or directory, access/,`
`61`		`- stack: /at async ok\.rejects/`
	`61`	`+ stack: /at async assert\.rejects/`
`62`	`62`	`}`
`63`	`63`	`).then(common.mustCall());`
`64`	`64`