src: set signal inspector io thread name

RafaelGSS · targos · commit 915d7aeb37d3 · 2025-02-07T13:12:46.000+01:00
PR-URL: #56416 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/doc/api/worker_threads.md b/doc/api/worker_threads.md
@@ -1235,7 +1235,9 @@ changes:
     * Maximum sizes:
       * Windows: 32,767 characters
       * macOS: 64 characters
-      * Other systems: 16 characters
+      * Linux: 16 characters
+      * NetBSD: limited to `PTHREAD_MAX_NAMELEN_NP`
+      * FreeBSD and OpenBSD: limited to `MAXCOMLEN`
         **Default:** `'WorkerThread'`.
 
 ### Event: `'error'`
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -86,6 +86,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {
 }
 
 inline void* StartIoThreadMain(void* unused) {
+  uv_thread_setname("SignalInspector");
   for (;;) {
     uv_sem_wait(&start_io_thread_semaphore);
     Mutex::ScopedLock lock(start_io_thread_async_mutex);
diff --git a/src/inspector_io.cc b/src/inspector_io.cc
@@ -286,7 +286,7 @@ void InspectorIo::ThreadMain() {
   int thread_name_error = uv_thread_setname("InspectorIo");
   if (!thread_name_error) [[unlikely]] {
     per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,
-        "Failed to set thread name for Inspector\n");
+                       "Failed to set thread name for Inspector\n");
   }
   uv_loop_t loop;
   loop.data = nullptr;

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`inline void* StartIoThreadMain(void* unused) {`
	`89`	`+ uv_thread_setname("SignalInspector");`
`89`	`90`	`for (;;) {`
`90`	`91`	`uv_sem_wait(&start_io_thread_semaphore);`
`91`	`92`	`Mutex::ScopedLock lock(start_io_thread_async_mutex);`
Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ void InspectorIo::ThreadMain() {`
`286`	`286`	`int thread_name_error = uv_thread_setname("InspectorIo");`
`287`	`287`	`if (!thread_name_error) [[unlikely]] {`
`288`	`288`	`per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,`
`289`		`- "Failed to set thread name for Inspector\n");`
	`289`	`+ "Failed to set thread name for Inspector\n");`
`290`	`290`	`}`
`291`	`291`	`uv_loop_t loop;`
`292`	`292`	`loop.data = nullptr;`