http: should support userland Agent

fengmk2 · jasnell · commit 90403dd1d06d · 2017-03-26T13:13:58.000-07:00
PR-URL: #11567 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -89,9 +89,9 @@ function ClientRequest(options, cb) {
     }
     // Explicitly pass through this statement as agent will not be used
     // when createConnection is provided.
-  } else if (!(agent instanceof Agent.Agent)) {
+  } else if (typeof agent.addRequest !== 'function') {
     throw new TypeError(
-      'Agent option must be an instance of http.Agent, undefined or false.'
+      'Agent option must be an Agent-like object, undefined, or false.'
     );
   }
   this.agent = agent;
diff --git a/test/parallel/test-http-client-reject-unexpected-agent.js b/test/parallel/test-http-client-reject-unexpected-agent.js
@@ -49,7 +49,7 @@ server.listen(0, baseOptions.host, common.mustCall(function() {
   failingAgentOptions.forEach((agent) => {
     assert.throws(
       () => createRequest(agent),
-      /^TypeError: Agent option must be an instance of http.Agent/,
+      /^TypeError: Agent option must be an Agent-like object/,
       `Expected typeof agent: ${typeof agent} to be rejected`
     );
   });

Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,9 @@ function ClientRequest(options, cb) {`
`89`	`89`	`}`
`90`	`90`	`// Explicitly pass through this statement as agent will not be used`
`91`	`91`	`// when createConnection is provided.`
`92`		`- } else if (!(agent instanceof Agent.Agent)) {`
	`92`	`+ } else if (typeof agent.addRequest !== 'function') {`
`93`	`93`	`throw new TypeError(`
`94`		`- 'Agent option must be an instance of http.Agent, undefined or false.'`
	`94`	`+ 'Agent option must be an Agent-like object, undefined, or false.'`
`95`	`95`	`);`
`96`	`96`	`}`
`97`	`97`	`this.agent = agent;`