src: refactor to nullptr in cpp code

gengjiawen · addaleax · commit 8cedfb81967d · 2019-02-07T18:54:21.000+01:00
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -395,7 +395,7 @@ void safe_free_hostent(struct hostent* host) {
       free(host->h_addr_list[idx++]);
     }
     free(host->h_addr_list);
-    host->h_addr_list = 0;
+    host->h_addr_list = nullptr;
   }
 
   if (host->h_aliases != nullptr) {
@@ -404,7 +404,7 @@ void safe_free_hostent(struct hostent* host) {
       free(host->h_aliases[idx++]);
     }
     free(host->h_aliases);
-    host->h_aliases = 0;
+    host->h_aliases = nullptr;
   }
 
   if (host->h_name != nullptr) {
@@ -1914,7 +1914,8 @@ void AfterGetNameInfo(uv_getnameinfo_t* req,
   req_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv);
 }
 
-using ParseIPResult = decltype(static_cast<ares_addr_port_node*>(0)->addr);
+using ParseIPResult =
+    decltype(static_cast<ares_addr_port_node*>(nullptr)->addr);
 
 int ParseIP(const char* ip, ParseIPResult* result = nullptr) {
   ParseIPResult tmp;
diff --git a/src/debug_utils.cc b/src/debug_utils.cc
@@ -66,7 +66,8 @@ class PosixSymbolDebuggingContext final : public NativeSymbolDebuggingContext {
       return ret;
 
     if (info.dli_sname != nullptr) {
-      if (char* demangled = abi::__cxa_demangle(info.dli_sname, 0, 0, 0)) {
+      if (char* demangled =
+              abi::__cxa_demangle(info.dli_sname, nullptr, nullptr, nullptr)) {
         ret.name = demangled;
         free(demangled);
       } else {
diff --git a/src/node.h b/src/node.h
@@ -562,13 +562,15 @@ extern "C" NODE_EXTERN void node_module_register(void* mod);
 /* Called after the event loop exits but before the VM is disposed.
  * Callbacks are run in reverse order of registration, i.e. newest first.
  */
-NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = 0);
+NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = nullptr);
 
 /* Registers a callback with the passed-in Environment instance. The callback
  * is called after the event loop exits, but before the VM is disposed.
  * Callbacks are run in reverse order of registration, i.e. newest first.
  */
-NODE_EXTERN void AtExit(Environment* env, void (*cb)(void* arg), void* arg = 0);
+NODE_EXTERN void AtExit(Environment* env,
+                        void (*cb)(void* arg),
+                        void* arg = nullptr);
 
 typedef void (*promise_hook_func) (v8::PromiseHookType type,
                                    v8::Local<v8::Promise> promise,
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -4818,7 +4818,7 @@ void DiffieHellman::Initialize(Environment* env, Local<Object> target) {
 
 bool DiffieHellman::Init(int primeLength, int g) {
   dh_.reset(DH_new());
-  if (!DH_generate_parameters_ex(dh_.get(), primeLength, g, 0))
+  if (!DH_generate_parameters_ex(dh_.get(), primeLength, g, nullptr))
     return false;
   return VerifyContext();
 }
@@ -4841,8 +4841,10 @@ bool DiffieHellman::Init(const char* p, int p_len, int g) {
 
 bool DiffieHellman::Init(const char* p, int p_len, const char* g, int g_len) {
   dh_.reset(DH_new());
-  BIGNUM* bn_p = BN_bin2bn(reinterpret_cast<const unsigned char*>(p), p_len, 0);
-  BIGNUM* bn_g = BN_bin2bn(reinterpret_cast<const unsigned char*>(g), g_len, 0);
+  BIGNUM* bn_p =
+      BN_bin2bn(reinterpret_cast<const unsigned char*>(p), p_len, nullptr);
+  BIGNUM* bn_g =
+      BN_bin2bn(reinterpret_cast<const unsigned char*>(g), g_len, nullptr);
   if (!DH_set0_pqg(dh_.get(), bn_p, nullptr, bn_g)) {
     BN_free(bn_p);
     BN_free(bn_g);
@@ -5010,7 +5012,7 @@ void DiffieHellman::ComputeSecret(const FunctionCallbackInfo<Value>& args) {
   BignumPointer key(BN_bin2bn(
       reinterpret_cast<unsigned char*>(Buffer::Data(args[0])),
       Buffer::Length(args[0]),
-      0));
+      nullptr));
 
   MallocedBuffer<char> data(DH_size(diffieHellman->dh_.get()));
 
diff --git a/src/util-inl.h b/src/util-inl.h
@@ -143,7 +143,7 @@ typename ListHead<T, M>::Iterator ListHead<T, M>::end() const {
 
 template <typename Inner, typename Outer>
 constexpr uintptr_t OffsetOf(Inner Outer::*field) {
-  return reinterpret_cast<uintptr_t>(&(static_cast<Outer*>(0)->*field));
+  return reinterpret_cast<uintptr_t>(&(static_cast<Outer*>(nullptr)->*field));
 }
 
 template <typename Inner, typename Outer>
diff --git a/src/util.cc b/src/util.cc
@@ -48,7 +48,7 @@ static void MakeUtf8String(Isolate* isolate,
   const int flags =
       String::NO_NULL_TERMINATION | String::REPLACE_INVALID_UTF8;
   const int length =
-      string->WriteUtf8(isolate, target->out(), storage, 0, flags);
+      string->WriteUtf8(isolate, target->out(), storage, nullptr, flags);
   target->SetLengthAndZeroTerminate(length);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ void safe_free_hostent(struct hostent* host) {`
`395`	`395`	`free(host->h_addr_list[idx++]);`
`396`	`396`	`}`
`397`	`397`	`free(host->h_addr_list);`
`398`		`- host->h_addr_list = 0;`
	`398`	`+ host->h_addr_list = nullptr;`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`if (host->h_aliases != nullptr) {`
`@@ -404,7 +404,7 @@ void safe_free_hostent(struct hostent* host) {`
`404`	`404`	`free(host->h_aliases[idx++]);`
`405`	`405`	`}`
`406`	`406`	`free(host->h_aliases);`
`407`		`- host->h_aliases = 0;`
	`407`	`+ host->h_aliases = nullptr;`
`408`	`408`	`}`
`409`	`409`
`410`	`410`	`if (host->h_name != nullptr) {`
`@@ -1914,7 +1914,8 @@ void AfterGetNameInfo(uv_getnameinfo_t* req,`
`1914`	`1914`	`req_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv);`
`1915`	`1915`	`}`
`1916`	`1916`
`1917`		`-using ParseIPResult = decltype(static_cast<ares_addr_port_node*>(0)->addr);`
	`1917`	`+using ParseIPResult =`
	`1918`	`+ decltype(static_cast<ares_addr_port_node*>(nullptr)->addr);`
`1918`	`1919`
`1919`	`1920`	`int ParseIP(const char* ip, ParseIPResult* result = nullptr) {`
`1920`	`1921`	`ParseIPResult tmp;`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ typename ListHead<T, M>::Iterator ListHead<T, M>::end() const {`
`143`	`143`
`144`	`144`	`template <typename Inner, typename Outer>`
`145`	`145`	`constexpr uintptr_t OffsetOf(Inner Outer::*field) {`
`146`		`- return reinterpret_cast<uintptr_t>(&(static_cast<Outer>(0)->field));`
	`146`	`+ return reinterpret_cast<uintptr_t>(&(static_cast<Outer>(nullptr)->field));`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`template <typename Inner, typename Outer>`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static void MakeUtf8String(Isolate* isolate,`
`48`	`48`	`const int flags =`
`49`	`49`	`String::NO_NULL_TERMINATION \| String::REPLACE_INVALID_UTF8;`
`50`	`50`	`const int length =`
`51`		`- string->WriteUtf8(isolate, target->out(), storage, 0, flags);`
	`51`	`+ string->WriteUtf8(isolate, target->out(), storage, nullptr, flags);`
`52`	`52`	`target->SetLengthAndZeroTerminate(length);`
`53`	`53`	`}`
`54`	`54`