test: deflake child-process-pipe-dataflow

lpinca · targos · commit 896073be471b · 2021-11-21T16:07:38.000+01:00
Fixes: #25988 PR-URL: #40838 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-child-process-pipe-dataflow.js b/test/parallel/test-child-process-pipe-dataflow.js
@@ -3,7 +3,6 @@ const common = require('../common');
 const assert = require('assert');
 const path = require('path');
 const fs = require('fs');
-const os = require('os');
 const spawn = require('child_process').spawn;
 const tmpdir = require('../common/tmpdir');
 
@@ -22,12 +21,13 @@ const MB = KB * KB;
   const file = path.resolve(tmpdir.path, 'data.txt');
   const buf = Buffer.alloc(MB).fill('x');
 
-  // Most OS commands that deal with data, attach special
-  // meanings to new line - for example, line buffering.
-  // So cut the buffer into lines at some points, forcing
-  // data flow to be split in the stream.
+  // Most OS commands that deal with data, attach special meanings to new line -
+  // for example, line buffering. So cut the buffer into lines at some points,
+  // forcing data flow to be split in the stream. Do not use os.EOL for \n as
+  // that is 2 characters on Windows and is sometimes converted to 1 character
+  // which causes the test to fail.
   for (let i = 1; i < KB; i++)
-    buf.write(os.EOL, i * KB);
+    buf.write('\n', i * KB);
   fs.writeFileSync(file, buf.toString());
 
   cat = spawn('cat', [file]);
