fs: fixup error message for invalid options.recursive

jasnell · addaleax · commit 8770fd96a728 · 2020-03-30T19:18:07.000+02:00
Use "options.recursive" instead of just "recursive" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32472 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/fs.js b/lib/fs.js
@@ -859,7 +859,7 @@ function mkdir(path, options, callback) {
   path = getValidatedPath(path);
 
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   const req = new FSReqCallback();
   req.oncomplete = callback;
@@ -878,7 +878,7 @@ function mkdirSync(path, options) {
 
   path = getValidatedPath(path);
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   const ctx = { path };
   const result = binding.mkdir(pathModule.toNamespacedPath(path),
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -346,7 +346,7 @@ async function mkdir(path, options) {
   } = options || {};
   path = getValidatedPath(path);
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   return binding.mkdir(pathModule.toNamespacedPath(path),
                        parseMode(mode, 'mode', 0o777), recursive,
diff --git a/test/parallel/test-fs-mkdir.js b/test/parallel/test-fs-mkdir.js
@@ -229,7 +229,7 @@ if (common.isMainThread && (common.isLinux || common.isOSX)) {
       {
         code: 'ERR_INVALID_ARG_TYPE',
         name: 'TypeError',
-        message: 'The "recursive" argument must be of type boolean.' +
+        message: 'The "options.recursive" property must be of type boolean.' +
           received
       }
     );
@@ -238,7 +238,7 @@ if (common.isMainThread && (common.isLinux || common.isOSX)) {
       {
         code: 'ERR_INVALID_ARG_TYPE',
         name: 'TypeError',
-        message: 'The "recursive" argument must be of type boolean.' +
+        message: 'The "options.recursive" property must be of type boolean.' +
           received
       }
     );

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ if (common.isMainThread && (common.isLinux \|\| common.isOSX)) {`
`229`	`229`	`{`
`230`	`230`	`code: 'ERR_INVALID_ARG_TYPE',`
`231`	`231`	`name: 'TypeError',`
`232`		`- message: 'The "recursive" argument must be of type boolean.' +`
	`232`	`+ message: 'The "options.recursive" property must be of type boolean.' +`
`233`	`233`	`received`
`234`	`234`	`}`
`235`	`235`	`);`
`@@ -238,7 +238,7 @@ if (common.isMainThread && (common.isLinux \|\| common.isOSX)) {`
`238`	`238`	`{`
`239`	`239`	`code: 'ERR_INVALID_ARG_TYPE',`
`240`	`240`	`name: 'TypeError',`
`241`		`- message: 'The "recursive" argument must be of type boolean.' +`
	`241`	`+ message: 'The "options.recursive" property must be of type boolean.' +`
`242`	`242`	`received`
`243`	`243`	`}`
`244`	`244`	`);`