test: convert test_encoding_binding.cc to a JS test · nodejs/node@86c199b · GitHub
Skip to content

Commit 86c199b

Browse files
legendecastargos
authored andcommitted
test: convert test_encoding_binding.cc to a JS test
The cctest file `test_encoding_binding.cc` is never tested and it is not a valid test. Binding functions should never be tested with V8 API circumvented. A binding function should only be tested with JS calls. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent bd54847 commit 86c199b

2 files changed

Lines changed: 48 additions & 176 deletions

File tree

test/cctest/test_encoding_binding.cc

Lines changed: 0 additions & 176 deletions
This file was deleted.
Lines changed: 48 additions & 0 deletions

0 commit comments

Comments
 (0)