async-hooks,net: ensure asyncId=null if no handle

Matt Sergeant · addaleax · commit 86c06c01ec51 · 2017-07-18T19:58:07.000+02:00
If the .listen() hasn't been called on the server, there is no handle object. In this case use null as the triggerAsyncId. Fixes: #13548 PR-URL: #13938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -1558,7 +1558,8 @@ Server.prototype.getConnections = function(cb) {
   const self = this;
 
   function end(err, connections) {
-    nextTick(self[async_id_symbol], cb, err, connections);
+    const asyncId = self._handle ? self[async_id_symbol] : null;
+    nextTick(asyncId, cb, err, connections);
   }
 
   if (!this._usingSlaves) {
diff --git a/test/async-hooks/test-net-get-connections.js b/test/async-hooks/test-net-get-connections.js
@@ -0,0 +1,11 @@
+'use strict';
+
+const common = require('../common');
+const net = require('net');
+const server = net.createServer();
+
+// This test was based on an error raised by Haraka.
+// It caused server.getConnections to raise an exception.
+// Ref: https://github.com/haraka/Haraka/pull/1951
+
+server.getConnections(common.mustCall());

Original file line number	Diff line number	Diff line change
`@@ -1558,7 +1558,8 @@ Server.prototype.getConnections = function(cb) {`
`1558`	`1558`	`const self = this;`
`1559`	`1559`
`1560`	`1560`	`function end(err, connections) {`
`1561`		`- nextTick(self[async_id_symbol], cb, err, connections);`
	`1561`	`+ const asyncId = self._handle ? self[async_id_symbol] : null;`
	`1562`	`+ nextTick(asyncId, cb, err, connections);`
`1562`	`1563`	`}`
`1563`	`1564`
`1564`	`1565`	`if (!this._usingSlaves) {`