tools,doc: use V8::DisposePlatform

targos · targos · commit 86b77f7d0fb4 · 2022-02-02T17:25:01.000+01:00
V8::ShutdownPlatform has been deprecated and does the same. PR-URL: #41610 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/doc/api/embedding.md b/doc/api/embedding.md
@@ -61,7 +61,7 @@ int main(int argc, char** argv) {
   int ret = RunNodeInstance(platform.get(), args, exec_args);
 
   V8::Dispose();
-  V8::ShutdownPlatform();
+  V8::DisposePlatform();
   return ret;
 }
 ```
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
@@ -98,7 +98,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {
     while (uv_loop_alive(&current_loop)) {
       uv_run(&current_loop, UV_RUN_ONCE);
     }
-    v8::V8::ShutdownPlatform();
+    v8::V8::DisposePlatform();
     CHECK_EQ(0, uv_loop_close(&current_loop));
   }
 
diff --git a/test/embedding/embedtest.cc b/test/embedding/embedtest.cc
@@ -40,7 +40,7 @@ int main(int argc, char** argv) {
   int ret = RunNodeInstance(platform.get(), args, exec_args);
 
   V8::Dispose();
-  V8::ShutdownPlatform();
+  V8::DisposePlatform();
   return ret;
 }
 
diff --git a/tools/code_cache/mkcodecache.cc b/tools/code_cache/mkcodecache.cc
@@ -68,6 +68,6 @@ int main(int argc, char* argv[]) {
   }
   isolate->Dispose();
 
-  v8::V8::ShutdownPlatform();
+  v8::V8::DisposePlatform();
   return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ int main(int argc, char** argv) {`
`61`	`61`	`int ret = RunNodeInstance(platform.get(), args, exec_args);`
`62`	`62`
`63`	`63`	`V8::Dispose();`
`64`		`- V8::ShutdownPlatform();`
	`64`	`+ V8::DisposePlatform();`
`65`	`65`	`return ret;`
`66`	`66`	`}`
`67`	`67`	```
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {`
`98`	`98`	`while (uv_loop_alive(&current_loop)) {`
`99`	`99`	`uv_run(&current_loop, UV_RUN_ONCE);`
`100`	`100`	`}`
`101`		`- v8::V8::ShutdownPlatform();`
	`101`	`+ v8::V8::DisposePlatform();`
`102`	`102`	`CHECK_EQ(0, uv_loop_close(&current_loop));`
`103`	`103`	`}`
`104`	`104`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ int main(int argc, char** argv) {`
`40`	`40`	`int ret = RunNodeInstance(platform.get(), args, exec_args);`
`41`	`41`
`42`	`42`	`V8::Dispose();`
`43`		`- V8::ShutdownPlatform();`
	`43`	`+ V8::DisposePlatform();`
`44`	`44`	`return ret;`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,6 @@ int main(int argc, char* argv[]) {`
`68`	`68`	`}`
`69`	`69`	`isolate->Dispose();`
`70`	`70`
`71`		`- v8::V8::ShutdownPlatform();`
	`71`	`+ v8::V8::DisposePlatform();`
`72`	`72`	`return 0;`
`73`	`73`	`}`