test: skip C++ symbols in tick-processor-arguments · nodejs/node@858702e · GitHub
Skip to content

Commit 858702e

Browse files
pipobscureaduh95
authored andcommitted
test: skip C++ symbols in tick-processor-arguments
The test only checks that a CLI flag is passed through to the V8 tick processor, but processing a --prof log makes the tick processor resolve the C++ symbols of every shared library listed in it by shelling out to nm (plus c++filt on macOS) once per library. On a --shared build that links around a hundred dylibs this takes longer than the test timeout on the macOS x86_64 GitHub Actions runner, and the outcome depends on the host toolchain rather than on node. Drop the shared-library entries from the log before processing it so the test exercises argument handling only. C++ symbol resolution is covered by test/tick-processor. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65906 Refs: #50050 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 70edf90 commit 858702e

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

‎test/parallel/test-tick-processor-arguments.js‎

Lines changed: 11 additions & 0 deletions

0 commit comments

Comments
 (0)