src: cache invariant code motion

RafaelGSS · marco-ippolito · commit 848c2d59fbfc · 2024-08-19T10:32:44.000+02:00
PR-URL: #53879 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -1650,11 +1650,12 @@ void Http2Session::HandleSettingsFrame(const nghttp2_frame* frame) {
         int32_t settings_id = iv[i].settings_id;
         if (settings_id >=
             IDX_SETTINGS_COUNT) {  // unsupported, additional settings
+          auto iv_value = iv[i].value;
           for (size_t j = 0; j < numsettings; ++j) {
             if ((remote_custom_settings_.entries[j].settings_id & 0xFFFF) ==
                 settings_id) {
               remote_custom_settings_.entries[j].settings_id = settings_id;
-              remote_custom_settings_.entries[j].value = iv[i].value;
+              remote_custom_settings_.entries[j].value = iv_value;
               break;
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -1650,11 +1650,12 @@ void Http2Session::HandleSettingsFrame(const nghttp2_frame* frame) {`
`1650`	`1650`	`int32_t settings_id = iv[i].settings_id;`
`1651`	`1651`	`if (settings_id >=`
`1652`	`1652`	`IDX_SETTINGS_COUNT) { // unsupported, additional settings`
	`1653`	`+ auto iv_value = iv[i].value;`
`1653`	`1654`	`for (size_t j = 0; j < numsettings; ++j) {`
`1654`	`1655`	`if ((remote_custom_settings_.entries[j].settings_id & 0xFFFF) ==`
`1655`	`1656`	`settings_id) {`
`1656`	`1657`	`remote_custom_settings_.entries[j].settings_id = settings_id;`
`1657`		`- remote_custom_settings_.entries[j].value = iv[i].value;`
	`1658`	`+ remote_custom_settings_.entries[j].value = iv_value;`
`1658`	`1659`	`break;`
`1659`	`1660`	`}`
`1660`	`1661`	`}`