util: assert: fix deepEqual comparing fake-boxed to real boxed primitive

ljharb · targos · commit 842607789865 · 2019-08-19T21:18:56.000+02:00
PR-URL: #29029 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -221,7 +221,9 @@ function innerDeepEqual(val1, val2, strict, memos) {
     if (!areEqualArrayBuffers(val1, val2)) {
       return false;
     }
-  } else if (isBoxedPrimitive(val1) && !isEqualBoxedPrimitive(val1, val2)) {
+  }
+  if ((isBoxedPrimitive(val1) || isBoxedPrimitive(val2)) &&
+    !isEqualBoxedPrimitive(val1, val2)) {
     return false;
   }
   return keyCheck(val1, val2, strict, memos, kNoIterator);

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,9 @@ function innerDeepEqual(val1, val2, strict, memos) {`
`221`	`221`	`if (!areEqualArrayBuffers(val1, val2)) {`
`222`	`222`	`return false;`
`223`	`223`	`}`
`224`		`- } else if (isBoxedPrimitive(val1) && !isEqualBoxedPrimitive(val1, val2)) {`
	`224`	`+ }`
	`225`	`+ if ((isBoxedPrimitive(val1) \|\| isBoxedPrimitive(val2)) &&`
	`226`	`+ !isEqualBoxedPrimitive(val1, val2)) {`
`225`	`227`	`return false;`
`226`	`228`	`}`
`227`	`229`	`return keyCheck(val1, val2, strict, memos, kNoIterator);`