src: disallow copy/move fns/constructors

anonrig · targos · commit 83ff7be9fd9a · 2025-02-10T15:16:06.000+01:00
PR-URL: #56811 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/src/debug_utils-inl.h b/src/debug_utils-inl.h
@@ -50,7 +50,7 @@ struct ToStringHelper {
   template <unsigned BASE_BITS,
             typename T,
             typename = std::enable_if_t<!std::is_integral_v<T>>>
-  static std::string BaseConvert(T value) {
+  static std::string BaseConvert(T& value) {  // NOLINT(runtime/references)
     return Convert(std::forward<T>(value));
   }
 };
diff --git a/src/util.h b/src/util.h
@@ -388,6 +388,11 @@ constexpr size_t strsize(const T (&)[N]) {
 template <typename T, size_t kStackStorageSize = 1024>
 class MaybeStackBuffer {
  public:
+  // Disallow copy constructor
+  MaybeStackBuffer(const MaybeStackBuffer&) = delete;
+  // Disallow copy assignment operator
+  MaybeStackBuffer& operator=(const MaybeStackBuffer& other) = delete;
+
   const T* out() const {
     return buf_;
   }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ struct ToStringHelper {`
`50`	`50`	`template <unsigned BASE_BITS,`
`51`	`51`	`typename T,`
`52`	`52`	`typename = std::enable_if_t<!std::is_integral_v<T>>>`
`53`		`- static std::string BaseConvert(T value) {`
	`53`	`+ static std::string BaseConvert(T& value) { // NOLINT(runtime/references)`
`54`	`54`	`return Convert(std::forward<T>(value));`
`55`	`55`	`}`
`56`	`56`	`};`