src: remove erroneous default argument in RadixTree

tniessen · RafaelGSS · commit 83ad272fa601 · 2023-11-29T09:46:32.000-03:00
This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target. PR-URL: #50736 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -172,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() {
 }
 
 bool FSPermission::RadixTree::Lookup(const std::string_view& s,
-                                     bool when_empty_return = false) const {
+                                     bool when_empty_return) const {
   FSPermission::RadixTree::Node* current_node = root_node_;
   if (current_node->children.size() == 0) {
     return when_empty_return;

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() {`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`bool FSPermission::RadixTree::Lookup(const std::string_view& s,`
`175`		`- bool when_empty_return = false) const {`
	`175`	`+ bool when_empty_return) const {`
`176`	`176`	`FSPermission::RadixTree::Node* current_node = root_node_;`
`177`	`177`	`if (current_node->children.size() == 0) {`
`178`	`178`	`return when_empty_return;`