src: perf_hooks: fix wrong sized delete

ofrobots · gibfahn · commit 826e7185093d · 2017-12-19T19:58:39.000Z
Depending on the allocator, existing code leaks memory. PR-URL: #16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
diff --git a/src/node_perf.cc b/src/node_perf.cc
@@ -196,7 +196,9 @@ void PerformanceGCCallback(uv_async_t* handle) {
 
  cleanup:
   delete data;
-  auto closeCB = [](uv_handle_t* handle) { delete handle; };
+  auto closeCB = [](uv_handle_t* handle) {
+    delete reinterpret_cast<uv_async_t*>(handle);
+  };
   uv_close(reinterpret_cast<uv_handle_t*>(handle), closeCB);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,9 @@ void PerformanceGCCallback(uv_async_t* handle) {`
`196`	`196`
`197`	`197`	`cleanup:`
`198`	`198`	`delete data;`
`199`		`- auto closeCB = [](uv_handle_t* handle) { delete handle; };`
	`199`	`+ auto closeCB = [](uv_handle_t* handle) {`
	`200`	`+ delete reinterpret_cast<uv_async_t*>(handle);`
	`201`	`+ };`
`200`	`202`	`uv_close(reinterpret_cast<uv_handle_t*>(handle), closeCB);`
`201`	`203`	`}`
`202`	`204`