test: prepare test-assert for strictEqual linting

Trott · MylesBorins · commit 8209ccb31320 · 2018-09-25T16:46:07.000-04:00
Make minor modifications to test-assert.js to prepare it for linting rule that forbids the use of string literals for the third argument of assert.strictEqual(). Backport-PR-URL: #22888 PR-URL: #22849 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -610,11 +610,11 @@ try {
 }
 
 try {
-  assert.strictEqual(1, 2, 'oh no');
+  assert.strictEqual(1, 2, 'oh no'); // eslint-disable-line no-restricted-syntax
 } catch (e) {
   assert.strictEqual(e.message.split('\n')[0], 'oh no');
-  assert.strictEqual(e.generatedMessage, false,
-                     'Message incorrectly marked as generated');
+  // Message should not be marked as generated.
+  assert.strictEqual(e.generatedMessage, false);
 }
 
 {

Original file line number	Diff line number	Diff line change
`@@ -610,11 +610,11 @@ try {`
`610`	`610`	`}`
`611`	`611`
`612`	`612`	`try {`
`613`		`- assert.strictEqual(1, 2, 'oh no');`
	`613`	`+ assert.strictEqual(1, 2, 'oh no'); // eslint-disable-line no-restricted-syntax`
`614`	`614`	`} catch (e) {`
`615`	`615`	`assert.strictEqual(e.message.split('\n')[0], 'oh no');`
`616`		`- assert.strictEqual(e.generatedMessage, false,`
`617`		`- 'Message incorrectly marked as generated');`
	`616`	`+ // Message should not be marked as generated.`
	`617`	`+ assert.strictEqual(e.generatedMessage, false);`
`618`	`618`	`}`
`619`	`619`
`620`	`620`	`{`