src,crypto: use ByteSource::ToBuffer() in crypto_dh

RaisinTen · danielleadams · commit 807536c54166 · 2022-01-31T23:00:04.000-05:00
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/src/crypto/crypto_dh.cc b/src/crypto/crypto_dh.cc
@@ -11,7 +11,6 @@
 
 namespace node {
 
-using v8::ArrayBuffer;
 using v8::ConstructorBehavior;
 using v8::DontDelete;
 using v8::FunctionCallback;
@@ -604,13 +603,8 @@ void DiffieHellman::Stateless(const FunctionCallbackInfo<Value>& args) {
   ManagedEVPPKey our_key = our_key_object->Data()->GetAsymmetricKey();
   ManagedEVPPKey their_key = their_key_object->Data()->GetAsymmetricKey();
 
-  Local<Value> out;
-  {
-    Local<ArrayBuffer> ab = StatelessDiffieHellmanThreadsafe(our_key, their_key)
-        .ToArrayBuffer(env);
-    out = Buffer::New(env, ab, 0, ab->ByteLength())
-        .FromMaybe(Local<Uint8Array>());
-  }
+  Local<Value> out = StatelessDiffieHellmanThreadsafe(our_key, their_key)
+      .ToBuffer(env).FromMaybe(Local<Uint8Array>());
 
   if (Buffer::Length(out) == 0)
     return ThrowCryptoError(env, ERR_get_error(), "diffieHellman failed");
