deps: V8: backport 9fb4444bfc46 · nodejs/node@801d1c7 · GitHub
Skip to content

Commit 801d1c7

Browse files
srl295nodejs-github-bot
authored andcommitted
deps: V8: backport 9fb4444bfc46
Original commit message: Fix Temporal compilation with system or no ICU build: Fix Temporal compilation with system or no ICU Add new build flag, v8_enable_temporal_systemicu, off by default When on, it will remove references to the internal ICU udatamem.h header file Obviates CLs 7769990 / 7831715 See: https://unicode-org.atlassian.net/browse/ICU-23400 See: Node: #62676 See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/7831715 See: Homebrew: Homebrew/homebrew-core#281707 Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Also includes: fix: fix for no-icu build thanks @aduh95 #62676 (comment) NO_IFTTT=No Temporal via Bazel Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8281487 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#110039} Refs: v8/v8@9fb4444 Fixes: #62676 Refs: srl295/v8@cd89fe6 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #66537 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 9384875 commit 801d1c7

5 files changed

Lines changed: 54 additions & 5 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion

‎deps/v8/AUTHORS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ Stefan Penner <stefan.penner@gmail.com>
310310
Stefan Stojanovic <stefko.stojanovic@gmail.com>
311311
Stephan Hartmann <stha09@googlemail.com>
312312
Stephen Belanger <stephen.belanger@datadoghq.com>
313+
Steven R. Loomis <srl295@gmail.com>
313314
Sylvestre Ledru <sledru@mozilla.com>
314315
Takeshi Yoneda <takeshi@tetrate.io>
315316
Taketoshi Aono <brn@b6n.ch>

‎deps/v8/BUILD.gn‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,6 +1439,9 @@ config("features") {
14391439
if (v8_enable_temporal_support) {
14401440
defines += [ "V8_TEMPORAL_SUPPORT" ]
14411441
}
1442+
if (v8_enable_temporal_systemicu) {
1443+
defines += [ "V8_ENABLE_TEMPORAL_SYSTEMICU" ]
1444+
}
14421445
if (v8_enable_local_handle_zapping) {
14431446
defines += [ "ENABLE_LOCAL_HANDLE_ZAPPING" ]
14441447
}
@@ -3469,6 +3472,7 @@ generated_file("v8_generate_features_json") {
34693472
v8_enable_hugepage = v8_enable_hugepage
34703473
v8_enable_i18n_support = v8_enable_i18n_support
34713474
v8_enable_temporal_support = v8_enable_temporal_support
3475+
v8_enable_temporal_systemicu = v8_enable_temporal_systemicu
34723476
v8_enable_javascript_promise_hooks = v8_enable_javascript_promise_hooks
34733477
v8_enable_lite_mode = v8_enable_lite_mode
34743478
v8_enable_map_packing = v8_enable_map_packing

‎deps/v8/gni/v8.gni‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ declare_args() {
6969
# Furthermore, some architectures don't have Rust toolchains in Chromium
7070
v8_enable_temporal_support = !(defined(build_with_node) && build_with_node)
7171

72+
# by default, don't enable compiling Temporal with a system ICU4C
73+
# (assume private headers are available)
74+
v8_enable_temporal_systemicu = false
75+
7276
# Use static libraries instead of source_sets.
7377
v8_static_library = false
7478

‎deps/v8/src/objects/js-temporal-zoneinfo64.cc‎

Lines changed: 44 additions & 4 deletions

0 commit comments

Comments
 (0)