repl: fix flaky test-repl-programmatic-history

mcollina · aduh95 · commit 7fb703078160 · 2026-02-08T10:10:44.000+01:00
The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly closed, causing ERR_INVALID_STATE errors when the handle was already closed by the GC finalizer. This fix adds an explicit closeHandle() method to ReplHistory and ensures that REPLServer.close() waits for the history file handle to be properly closed before completing the close operation. Refs: nodejs/reliability#1450 PR-URL: #61614 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/lib/internal/repl/history.js b/lib/internal/repl/history.js
@@ -58,6 +58,7 @@ const kResolveHistoryPath = Symbol('_kResolveHistoryPath');
 const kReplHistoryMessage = Symbol('_kReplHistoryMessage');
 const kFlushHistory = Symbol('_kFlushHistory');
 const kGetHistoryPath = Symbol('_kGetHistoryPath');
+const kCloseHandle = Symbol('_kCloseHandle');
 
 class ReplHistory {
   constructor(context, options) {
@@ -393,15 +394,29 @@ class ReplHistory {
     }
     this[kContext].off('line', this[kOnLine].bind(this));
 
+    await this[kCloseHandle]();
+  }
+
+  async [kCloseHandle]() {
     if (this[kHistoryHandle] !== null) {
+      const handle = this[kHistoryHandle];
+      this[kHistoryHandle] = null;
       try {
-        await this[kHistoryHandle].close();
+        await handle.close();
       } catch (err) {
         debug('Error closing history file:', err);
       }
     }
   }
 
+  /**
+   * Closes the history file handle.
+   * @returns {Promise<void>}
+   */
+  closeHandle() {
+    return this[kCloseHandle]();
+  }
+
   [kReplHistoryMessage]() {
     if (this[kHistory].length === 0) {
       ReplHistory[kWriteToOutput](
diff --git a/lib/repl.js b/lib/repl.js
@@ -1039,12 +1039,18 @@ class REPLServer extends Interface {
     this[kBufferedCommandSymbol] = '';
   }
   close() {
-    if (this.terminal && this.historyManager.isFlushing && !this._closingOnFlush) {
+    if (this.terminal && this.historyManager?.isFlushing && !this._closingOnFlush) {
       this._closingOnFlush = true;
-      this.once('flushHistory', () => super.close());
+      this.once('flushHistory', () => this.close());
 
       return;
     }
+    // Ensure the history file handle is closed before completing
+    if (this.terminal && this.historyManager?.closeHandle && !this._historyHandleClosed) {
+      this._historyHandleClosed = true;
+      this.historyManager.closeHandle().then(() => super.close());
+      return;
+    }
     process.nextTick(() => super.close());
   }
   createContext() {
