test: fix flaky test-bench-stream · nodejs/node@7f51681 · GitHub
Skip to content

Commit 7f51681

Browse files
mcollinaaduh95
authored andcommitted
test: fix flaky test-bench-stream
testDeliveryDoesNotConsumeTimeout gave the benchmark a 20ms timeout while stalling the consumer for 50ms. Only delivery time is credited back to the deadline, so the 32 samples still had to run within 20ms, which is about a 10x margin on an idle machine and not enough on a loaded CI runner. Scale the timeout and the stall together so the benchmark's own work gets 500ms of headroom while the consumer still stalls for longer than the timeout. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65874 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 08f96f1 commit 7f51681

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

‎test/parallel/test-bench-stream.js‎

Lines changed: 9 additions & 3 deletions

0 commit comments

Comments
 (0)