ffi: validate 'void' as parameter type in getFunction and getFunctions

Anshikakalpana · aduh95 · commit 7f41f5d80328 · 2026-05-27T11:35:50.000+02:00
Fixes: #63461 Signed-off-by: Anshikakalpana <anshikajain196872@gmail.com> PR-URL: #63504 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/src/ffi/types.cc b/src/ffi/types.cc
@@ -164,6 +164,15 @@ Maybe<FunctionSignature> ParseFunctionSignature(Environment* env,
       if (!ToFFIType(env, arg_str.ToStringView()).To(&arg_type)) {
         return {};
       }
+      if (arg_type == &ffi_type_void) {
+        THROW_ERR_INVALID_ARG_VALUE(
+            env,
+            "Argument %u of function %s must not be 'void'; "
+            "use an empty array for no-argument functions",
+            i,
+            name);
+        return {};
+      }
 
       args.push_back(arg_type);
       arg_type_names.emplace_back(arg_str.ToString());
diff --git a/test/ffi/test-ffi-void-parameter.js b/test/ffi/test-ffi-void-parameter.js
@@ -0,0 +1,29 @@
+// Flags: --experimental-ffi
+'use strict';
+
+const common = require('../common');
+common.skipIfFFIMissing();
+
+const assert = require('node:assert');
+const ffi = require('node:ffi');
+const { libraryPath } = require('./ffi-test-common');
+
+// Regression test for https://github.com/nodejs/node/issues/63461
+// 'void' as a parameter type should throw ERR_INVALID_ARG_VALUE
+// instead of triggering ERR_INTERNAL_ASSERTION.
+
+const lib = new ffi.DynamicLibrary(libraryPath);
+
+try {
+  assert.throws(() => {
+    lib.getFunction('add_i32', { return: 'i32', arguments: ['void'] });
+  }, { code: 'ERR_INVALID_ARG_VALUE' });
+
+  assert.throws(() => {
+    lib.getFunctions({
+      add_i32: { return: 'i32', arguments: ['void'] },
+    });
+  }, { code: 'ERR_INVALID_ARG_VALUE' });
+} finally {
+  lib.close();
+}
