crypto: make webcrypto aliasKeyFormat directional

panva · aduh95 · commit 7e9ca87e5847 · 2026-06-18T10:11:23.000+02:00
The helper no longer treats every raw alias the same way and unintended values were accepted for some algorithms. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #63910 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/lib/internal/crypto/webcrypto.js b/lib/internal/crypto/webcrypto.js
@@ -837,14 +837,8 @@ function parseJwk(data) {
   return key;
 }
 
-function aliasKeyFormat(format) {
-  switch (format) {
-    case 'raw-public':
-    case 'raw-secret':
-      return 'raw';
-    default:
-      return format;
-  }
+function aliasKeyFormat(format, alias) {
+  return format === alias ? 'raw' : format;
 }
 
 function importKeySync(format, keyData, algorithm, extractable, usages) {
@@ -855,7 +849,6 @@ function importKeySync(format, keyData, algorithm, extractable, usages) {
     case 'RSA-PSS':
       // Fall through
     case 'RSA-OAEP':
-      format = aliasKeyFormat(format);
       result = require('internal/crypto/rsa')
         .rsaImportKey(
           format,
@@ -867,7 +860,7 @@ function importKeySync(format, keyData, algorithm, extractable, usages) {
     case 'ECDSA':
       // Fall through
     case 'ECDH':
-      format = aliasKeyFormat(format);
+      format = aliasKeyFormat(format, 'raw-public');
       result = require('internal/crypto/ec')
         .ecImportKey(
           format,
@@ -883,7 +876,7 @@ function importKeySync(format, keyData, algorithm, extractable, usages) {
     case 'X25519':
       // Fall through
     case 'X448':
-      format = aliasKeyFormat(format);
+      format = aliasKeyFormat(format, 'raw-public');
       result = require('internal/crypto/cfrg')
         .cfrgImportKey(
           format,
@@ -934,7 +927,7 @@ function importKeySync(format, keyData, algorithm, extractable, usages) {
     case 'HKDF':
       // Fall through
     case 'PBKDF2':
-      format = aliasKeyFormat(format);
+      format = aliasKeyFormat(format, 'raw-secret');
       result = importGenericSecretKey(
         algorithm,
         format,
diff --git a/test/parallel/test-webcrypto-raw-format-aliases.js b/test/parallel/test-webcrypto-raw-format-aliases.js
@@ -0,0 +1,72 @@
+'use strict';
+
+const common = require('../common');
+
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const { subtle } = globalThis.crypto;
+
+function getAlgorithmName(algorithm) {
+  return typeof algorithm === 'string' ? algorithm : algorithm.name;
+}
+
+function assertImportNotSupported(format, keyData, algorithm, extractable, usages) {
+  return assert.rejects(
+    subtle.importKey(format, keyData, algorithm, extractable, usages),
+    {
+      name: 'NotSupportedError',
+      message: `Unable to import ${getAlgorithmName(algorithm)} using ${format} format`,
+    });
+}
+
+async function assertSecretKeyDoesNotAcceptRawPublic(algorithm) {
+  const keyData = new Uint8Array(32);
+  await assertImportNotSupported(
+    'raw-public',
+    keyData,
+    algorithm,
+    false,
+    ['deriveBits']);
+}
+
+async function assertPublicKeyDoesNotAcceptRawSecret(
+  algorithm,
+  generateUsages,
+  importUsages,
+) {
+  const { publicKey } = await subtle.generateKey(
+    algorithm,
+    true,
+    generateUsages);
+  const keyData = await subtle.exportKey('raw', publicKey);
+
+  await assertImportNotSupported(
+    'raw-secret',
+    keyData,
+    algorithm,
+    true,
+    importUsages);
+}
+
+Promise.all([
+  assertSecretKeyDoesNotAcceptRawPublic('HKDF'),
+  assertSecretKeyDoesNotAcceptRawPublic('PBKDF2'),
+  assertPublicKeyDoesNotAcceptRawSecret(
+    { name: 'ECDSA', namedCurve: 'P-256' },
+    ['sign', 'verify'],
+    ['verify']),
+  assertPublicKeyDoesNotAcceptRawSecret(
+    { name: 'ECDH', namedCurve: 'P-256' },
+    ['deriveBits'],
+    []),
+  assertPublicKeyDoesNotAcceptRawSecret(
+    'Ed25519',
+    ['sign', 'verify'],
+    ['verify']),
+  assertPublicKeyDoesNotAcceptRawSecret(
+    'X25519',
+    ['deriveBits'],
+    []),
+]).then(common.mustCall());
