src: update GetForegroundTaskRunner override

etiennep-chromium · targos · commit 7e8752006a97 · 2025-01-31T12:47:12.000+01:00
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5758110 PR-URL: #55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -556,8 +556,8 @@ bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {
   return ForIsolate(isolate)->IdleTasksEnabled();
 }
 
-std::shared_ptr<v8::TaskRunner>
-NodePlatform::GetForegroundTaskRunner(Isolate* isolate) {
+std::shared_ptr<v8::TaskRunner> NodePlatform::GetForegroundTaskRunner(
+    Isolate* isolate, v8::TaskPriority priority) {
   return ForIsolate(isolate)->GetForegroundTaskRunner();
 }
 
diff --git a/src/node_platform.h b/src/node_platform.h
@@ -182,7 +182,7 @@ class NodePlatform : public MultiIsolatePlatform {
                                   void* data) override;
 
   std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
-      v8::Isolate* isolate) override;
+      v8::Isolate* isolate, v8::TaskPriority priority) override;
 
   Platform::StackTracePrinter GetStackTracePrinter() override;
   v8::PageAllocator* GetPageAllocator() override;
diff --git a/test/cctest/test_platform.cc b/test/cctest/test_platform.cc
@@ -24,7 +24,8 @@ class RepostingTask : public v8::Task {
     if (repost_count_ > 0) {
       --repost_count_;
       std::shared_ptr<v8::TaskRunner> task_runner =
-          platform_->GetForegroundTaskRunner(isolate_);
+          platform_->GetForegroundTaskRunner(isolate_,
+                                             v8::TaskPriority::kUserBlocking);
       task_runner->PostTask(std::make_unique<RepostingTask>(
           repost_count_, run_count_, isolate_, platform_));
     }
@@ -46,7 +47,8 @@ TEST_F(PlatformTest, SkipNewTasksInFlushForegroundTasks) {
   Env env {handle_scope, argv};
   int run_count = 0;
   std::shared_ptr<v8::TaskRunner> task_runner =
-      platform->GetForegroundTaskRunner(isolate_);
+      platform->GetForegroundTaskRunner(isolate_,
+                                        v8::TaskPriority::kUserBlocking);
   task_runner->PostTask(
       std::make_unique<RepostingTask>(2, &run_count, isolate_, platform.get()));
   EXPECT_TRUE(platform->FlushForegroundTasks(isolate_));

Original file line number	Diff line number	Diff line change
`@@ -556,8 +556,8 @@ bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {`
`556`	`556`	`return ForIsolate(isolate)->IdleTasksEnabled();`
`557`	`557`	`}`
`558`	`558`
`559`		`-std::shared_ptr<v8::TaskRunner>`
`560`		`-NodePlatform::GetForegroundTaskRunner(Isolate* isolate) {`
	`559`	`+std::shared_ptr<v8::TaskRunner> NodePlatform::GetForegroundTaskRunner(`
	`560`	`+ Isolate* isolate, v8::TaskPriority priority) {`
`561`	`561`	`return ForIsolate(isolate)->GetForegroundTaskRunner();`
`562`	`562`	`}`
`563`	`563`