src: move instead of copy shared pointer in node_blob

targos · targos · commit 7dd326e3a76e · 2025-02-25T17:51:00.000+01:00
Resolves a new warning reported by Coverity. PR-URL: #57120 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_blob.cc b/src/node_blob.cc
@@ -207,7 +207,7 @@ void Blob::New(const FunctionCallbackInfo<Value>& args) {
           return nullptr;
         }
         return DataQueue::CreateInMemoryEntryFromBackingStore(
-            store, byte_offset, byte_length);
+            std::move(store), byte_offset, byte_length);
       }
 
       // If the ArrayBuffer is not detachable, we will copy from it instead.
@@ -216,7 +216,7 @@ void Blob::New(const FunctionCallbackInfo<Value>& args) {
       uint8_t* ptr = static_cast<uint8_t*>(buf->Data()) + byte_offset;
       std::copy(ptr, ptr + byte_length, static_cast<uint8_t*>(store->Data()));
       return DataQueue::CreateInMemoryEntryFromBackingStore(
-          store, 0, byte_length);
+          std::move(store), 0, byte_length);
     };
 
     // Every entry should be either an ArrayBuffer, ArrayBufferView, or Blob.
