src: use BaseObjectPtr to store SNI context

addaleax · addaleax · commit 7bd587ef0cd5 · 2019-11-30T03:57:58.000+01:00
Rather than relying on a link to the JS object, store a pointer to the C++ object directly. PR-URL: #30548 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -2991,9 +2991,15 @@ void SSLWrap<Base>::CertCbDone(const FunctionCallbackInfo<Value>& args) {
     goto fire_cb;
 
   if (cons->HasInstance(ctx)) {
-    SecureContext* sc;
-    ASSIGN_OR_RETURN_UNWRAP(&sc, ctx.As<Object>());
-    w->sni_context_.Reset(env->isolate(), ctx);
+    SecureContext* sc = Unwrap<SecureContext>(ctx.As<Object>());
+    CHECK_NOT_NULL(sc);
+    // XXX: There is a method w->SetSNIContext(sc), and you might think that
+    // it makes sense to call that here and make setting w->sni_context_ part
+    // of it. In fact, that passes the test suite, although SetSNIContext()
+    // performs a lot more operations.
+    // If anybody is familiar enough with the TLS code to know whether it makes
+    // sense, please do so or document why it doesn't.
+    w->sni_context_ = BaseObjectPtr<SecureContext>(sc);
 
     int rv;
 
diff --git a/src/node_crypto.h b/src/node_crypto.h
@@ -310,7 +310,7 @@ class SSLWrap {
   ClientHelloParser hello_parser_;
 
   v8::Global<v8::ArrayBufferView> ocsp_response_;
-  v8::Global<v8::Value> sni_context_;
+  BaseObjectPtr<SecureContext> sni_context_;
 
   friend class SecureContext;
 };
diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -1065,10 +1065,9 @@ int TLSWrap::SelectSNIContextCallback(SSL* s, int* ad, void* arg) {
     return SSL_TLSEXT_ERR_NOACK;
   }
 
-  p->sni_context_.Reset(env->isolate(), ctx);
-
   SecureContext* sc = Unwrap<SecureContext>(ctx.As<Object>());
   CHECK_NOT_NULL(sc);
+  p->sni_context_ = BaseObjectPtr<SecureContext>(sc);
   p->SetSNIContext(sc);
   return SSL_TLSEXT_ERR_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -1065,10 +1065,9 @@ int TLSWrap::SelectSNIContextCallback(SSL* s, int* ad, void* arg) {`
`1065`	`1065`	`return SSL_TLSEXT_ERR_NOACK;`
`1066`	`1066`	`}`
`1067`	`1067`
`1068`		`- p->sni_context_.Reset(env->isolate(), ctx);`
`1069`		`-`
`1070`	`1068`	`SecureContext* sc = Unwrap<SecureContext>(ctx.As<Object>());`
`1071`	`1069`	`CHECK_NOT_NULL(sc);`
	`1070`	`+ p->sni_context_ = BaseObjectPtr<SecureContext>(sc);`
`1072`	`1071`	`p->SetSNIContext(sc);`
`1073`	`1072`	`return SSL_TLSEXT_ERR_OK;`
`1074`	`1073`	`}`