bootstrap: correct --frozen-intrinsics override fix

guybedford · addaleax · commit 7bc26c2e8c6b · 2020-09-22T19:56:54.000+02:00
PR-URL: #35041 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -384,8 +384,8 @@ module.exports = function() {
           defineProperty(this, prop, {
             value: newValue,
             writable: true,
-            enumerable: desc.enumerable,
-            configurable: desc.configurable
+            enumerable: true,
+            configurable: true
           });
         }
       }
diff --git a/test/parallel/test-freeze-intrinsics.js b/test/parallel/test-freeze-intrinsics.js
@@ -27,4 +27,6 @@ assert.throws(
   const o = {};
   o.toString = () => 'Custom toString';
   assert.strictEqual(o + 'asdf', 'Custom toStringasdf');
+  assert.strictEqual(Object.getOwnPropertyDescriptor(o, 'toString').enumerable,
+                     true);
 }

Original file line number	Diff line number	Diff line change
`@@ -384,8 +384,8 @@ module.exports = function() {`
`384`	`384`	`defineProperty(this, prop, {`
`385`	`385`	`value: newValue,`
`386`	`386`	`writable: true,`
`387`		`- enumerable: desc.enumerable,`
`388`		`- configurable: desc.configurable`
	`387`	`+ enumerable: true,`
	`388`	`+ configurable: true`
`389`	`389`	`});`
`390`	`390`	`}`
`391`	`391`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,4 +27,6 @@ assert.throws(`
`27`	`27`	`const o = {};`
`28`	`28`	`o.toString = () => 'Custom toString';`
`29`	`29`	`assert.strictEqual(o + 'asdf', 'Custom toStringasdf');`
	`30`	`+ assert.strictEqual(Object.getOwnPropertyDescriptor(o, 'toString').enumerable,`
	`31`	`+ true);`
`30`	`32`	`}`