inspector: do not spin-wait while waiting for the initial connection

eugeneo · targos · commit 7b0b06d735c9 · 2019-07-22T21:20:42.000+02:00
Fixes: #28741 PR-URL: #28756 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -699,8 +699,7 @@ class NodeInspectorClient : public V8InspectorClient {
 
     MultiIsolatePlatform* platform = env_->isolate_data()->platform();
     while (shouldRunMessageLoop()) {
-      if (interface_ && hasConnectedSessions())
-        interface_->WaitForFrontendEvent();
+      if (interface_) interface_->WaitForFrontendEvent();
       while (platform->FlushForegroundTasks(env_->isolate())) {}
     }
     running_nested_loop_ = false;

Original file line number	Diff line number	Diff line change
`@@ -699,8 +699,7 @@ class NodeInspectorClient : public V8InspectorClient {`
`699`	`699`
`700`	`700`	`MultiIsolatePlatform* platform = env_->isolate_data()->platform();`
`701`	`701`	`while (shouldRunMessageLoop()) {`
`702`		`- if (interface_ && hasConnectedSessions())`
`703`		`- interface_->WaitForFrontendEvent();`
	`702`	`+ if (interface_) interface_->WaitForFrontendEvent();`
`704`	`703`	`while (platform->FlushForegroundTasks(env_->isolate())) {}`
`705`	`704`	`}`
`706`	`705`	`running_nested_loop_ = false;`