build,tools: fix addon build deadlock on errors

vmoroz · aduh95 · commit 775c77234b68 · 2026-01-27T22:50:36.000+01:00
PR-URL: #61321 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/tools/build_addons.py b/tools/build_addons.py
@@ -58,8 +58,8 @@ def node_gyp_rebuild(test_dir):
 
       # We buffer the output and print it out once the process is done in order
       # to avoid interleaved output from multiple builds running at once.
-      return_code = process.wait()
       stdout, stderr = process.communicate()
+      return_code = process.returncode
       if return_code != 0:
         print(f'Failed to build addon in {test_dir}:')
         if stdout:
