src: don't check failure with ERR_peek_error()

bnoordhuis · bnoordhuis · commit 761cf2bf6a67 · 2016-01-18T10:04:02.000+01:00
It's possible there is already an existing error on OpenSSL's error stack that is unrelated to the EVP_DigestInit_ex() operation we just executed. Fixes: #4221 PR-URL: #4731 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3611,8 +3611,7 @@ bool Hash::HashInit(const char* hash_type) {
   if (md_ == nullptr)
     return false;
   EVP_MD_CTX_init(&mdctx_);
-  EVP_DigestInit_ex(&mdctx_, md_, nullptr);
-  if (0 != ERR_peek_error()) {
+  if (EVP_DigestInit_ex(&mdctx_, md_, nullptr) <= 0) {
     return false;
   }
   initialised_ = true;
