deps: cherry-pick 43547df from V8 upstream · nodejs/node@75b37a6 · GitHub
Skip to content

Commit 75b37a6

Browse files
fhinkelofrobots
authored andcommitted
deps: cherry-pick 43547df from V8 upstream
Original commit message: [crankshaft] Don't inline "dont_crankshaft" functions Crankshaft shouldn't try to inline functions it knows it can't handle. BUG=v8:5033 Review-Url: https://codereview.chromium.org/2000703002 Cr-Commit-Position: refs/heads/master@{#36417} Fixes: #6883 PR-URL: #7863 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
1 parent af63871 commit 75b37a6

3 files changed

Lines changed: 26 additions & 1 deletion

File tree

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion

deps/v8/src/crankshaft/hydrogen.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8423,6 +8423,10 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
84238423
TraceInline(target, caller, "parse failure");
84248424
return false;
84258425
}
8426+
if (target_shared->dont_crankshaft()) {
8427+
TraceInline(target, caller, "ParseAndAnalyze found incompatibility");
8428+
return false;
8429+
}
84268430

84278431
if (target_info.scope()->num_heap_slots() > 0) {
84288432
TraceInline(target, caller, "target has context-allocated variables");
Lines changed: 21 additions & 0 deletions

0 commit comments

Comments
 (0)