stream: be less eager with readable flag

mscdex · rvagg · commit 756ab9caadcb · 2015-12-05T17:42:55.000+11:00
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: #4125 PR-URL: #4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -385,7 +385,6 @@ function onEofChunk(stream, state) {
     }
   }
   state.ended = true;
-  stream.readable = false;
 
   // emit 'readable' now to make sure it gets picked up.
   emitReadable(stream);

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,6 @@ function onEofChunk(stream, state) {`
`385`	`385`	`}`
`386`	`386`	`}`
`387`	`387`	`state.ended = true;`
`388`		`- stream.readable = false;`
`389`	`388`
`390`	`389`	`// emit 'readable' now to make sure it gets picked up.`
`391`	`390`	`emitReadable(stream);`