benchmark: check end() argument to be > 0

vsemozhetbyt · MylesBorins · commit 751c1153a4eb · 2017-03-28T19:26:58.000-04:00
PR-URL: #12030 Ref: #11972 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/benchmark/common.js b/benchmark/common.js
@@ -193,6 +193,9 @@ Benchmark.prototype.end = function(operations) {
   if (typeof operations !== 'number') {
     throw new Error('called end() without specifying operation count');
   }
+  if (!process.env.NODEJS_BENCHMARK_ZERO_ALLOWED && operations <= 0) {
+    throw new Error('called end() with operation count <= 0');
+  }
 
   const time = elapsed[0] + elapsed[1] / 1e9;
   const rate = operations / time;
diff --git a/test/sequential/test-benchmark-net.js b/test/sequential/test-benchmark-net.js
@@ -15,7 +15,8 @@ const path = require('path');
 
 const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js');
 
-const child = fork(runjs, ['--set', 'dur=0', 'net']);
+const child = fork(runjs, ['--set', 'dur=0', 'net'],
+                   {env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}});
 child.on('exit', (code, signal) => {
   assert.strictEqual(code, 0);
   assert.strictEqual(signal, null);

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,9 @@ Benchmark.prototype.end = function(operations) {`
`193`	`193`	`if (typeof operations !== 'number') {`
`194`	`194`	`throw new Error('called end() without specifying operation count');`
`195`	`195`	`}`
	`196`	`+ if (!process.env.NODEJS_BENCHMARK_ZERO_ALLOWED && operations <= 0) {`
	`197`	`+ throw new Error('called end() with operation count <= 0');`
	`198`	`+ }`
`196`	`199`
`197`	`200`	`const time = elapsed[0] + elapsed[1] / 1e9;`
`198`	`201`	`const rate = operations / time;`