test_runner: match minimum file column to 'all files'

islandryu · RafaelGSS · commit 7416a7f35ad0 · 2025-05-02T17:06:23.000-03:00
PR-URL: #57848 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -468,7 +468,7 @@ function getCoverageReport(pad, summary, symbol, color, table) {
     if (color) {
       filePadLength += 2;
     }
-    filePadLength = MathMax(filePadLength, 'file'.length);
+    filePadLength = MathMax(filePadLength, 'all files'.length);
     if (filePadLength > (process.stdout.columns / 2)) {
       filePadLength = MathFloor(process.stdout.columns / 2);
     }
diff --git a/test/fixtures/test-runner/output/coverage-short-filename.mjs b/test/fixtures/test-runner/output/coverage-short-filename.mjs
@@ -0,0 +1,9 @@
+// Flags: --experimental-test-coverage
+// here we can't import common module as the coverage will be different based on the system
+// Unused imports are here in order to populate the coverage report
+// eslint-disable-next-line no-unused-vars
+import * as a from '../coverage-snap/a.js';
+
+import { test } from 'node:test';
+
+test(`Coverage Print Short Filename`);
diff --git a/test/fixtures/test-runner/output/coverage-short-filename.snapshot b/test/fixtures/test-runner/output/coverage-short-filename.snapshot
@@ -0,0 +1,25 @@
+TAP version 13
+# Subtest: Coverage Print Short Filename
+ok 1 - Coverage Print Short Filename
+  ---
+  duration_ms: *
+  type: 'test'
+  ...
+1..1
+# tests 1
+# suites 0
+# pass 1
+# fail 0
+# cancelled 0
+# skipped 0
+# todo 0
+# duration_ms *
+# start of coverage report
+# ---------------------------------------------------------------------------------------
+# file      | line % | branch % | funcs % | uncovered lines
+# ---------------------------------------------------------------------------------------
+# a.js      |  55.77 |   100.00 |    0.00 | 5-7 9-11 13-15 17-19 29-30 40-42 45-47 50-52
+# ---------------------------------------------------------------------------------------
+# all files |  55.77 |   100.00 |    0.00 | 
+# ---------------------------------------------------------------------------------------
+# end of coverage report
diff --git a/test/parallel/test-runner-output.mjs b/test/parallel/test-runner-output.mjs
@@ -308,12 +308,17 @@ const tests = [
     name: 'test-runner/output/coverage-width-infinity-uncovered-lines.mjs',
     flags: ['--test-reporter=tap', '--test-coverage-exclude=!test/**'],
   } : false,
+  process.features.inspector ? {
+    name: 'test-runner/output/coverage-short-filename.mjs',
+    flags: ['--test-reporter=tap', '--test-coverage-exclude=../output/**'],
+    cwd: fixtures.path('test-runner/coverage-snap'),
+  } : false,
 ]
 .filter(Boolean)
-.map(({ flags, name, tty, transform }) => ({
+.map(({ flags, name, tty, transform, cwd }) => ({
   name,
   fn: common.mustCall(async () => {
-    await snapshot.spawnAndAssert(fixtures.path(name), transform ?? defaultTransform, { tty, flags });
+    await snapshot.spawnAndAssert(fixtures.path(name), transform ?? defaultTransform, { tty, flags, cwd });
   }),
 }));
 

Original file line number	Diff line number	Diff line change
`@@ -468,7 +468,7 @@ function getCoverageReport(pad, summary, symbol, color, table) {`
`468`	`468`	`if (color) {`
`469`	`469`	`filePadLength += 2;`
`470`	`470`	`}`
`471`		`- filePadLength = MathMax(filePadLength, 'file'.length);`
	`471`	`+ filePadLength = MathMax(filePadLength, 'all files'.length);`
`472`	`472`	`if (filePadLength > (process.stdout.columns / 2)) {`
`473`	`473`	`filePadLength = MathFloor(process.stdout.columns / 2);`
`474`	`474`	`}`