test: update wpt test for webmessaging/broadcastchannel

Nahee-Park · ruyadorno · commit 73ab14fd8f3c · 2024-11-27T02:25:38.000-05:00
PR-URL: #55205 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/fixtures/wpt/README.md b/test/fixtures/wpt/README.md
@@ -34,7 +34,7 @@ Last update:
 - wasm/webapi: https://github.com/web-platform-tests/wpt/tree/fd1b23eeaa/wasm/webapi
 - WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/bef6fa3566/WebCryptoAPI
 - webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions
-- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/e97fac4791/webmessaging/broadcastchannel
+- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel
 - webstorage: https://github.com/web-platform-tests/wpt/tree/9dafa89214/webstorage
 
 [Web Platform Tests]: https://github.com/web-platform-tests/wpt
diff --git a/test/fixtures/wpt/versions.json b/test/fixtures/wpt/versions.json
@@ -96,7 +96,7 @@
     "path": "webidl/ecmascript-binding/es-exceptions"
   },
   "webmessaging/broadcastchannel": {
-    "commit": "e97fac4791931fb7455ba3fad759d362c7108b09",
+    "commit": "6495c91853a3cf028a401cf4d228fc0b6a5465e4",
     "path": "webmessaging/broadcastchannel"
   },
   "webstorage": {
diff --git a/test/fixtures/wpt/webmessaging/broadcastchannel/WEB_FEATURES.yml b/test/fixtures/wpt/webmessaging/broadcastchannel/WEB_FEATURES.yml
@@ -0,0 +1,3 @@
+features:
+- name: broadcast-channel
+  files: "**"
diff --git a/test/fixtures/wpt/webmessaging/broadcastchannel/basics.any.js b/test/fixtures/wpt/webmessaging/broadcastchannel/basics.any.js
@@ -1,3 +1,11 @@
+test(function() {
+  assert_throws_js(
+      TypeError,
+      () => BroadcastChannel(""),
+      "Calling BroadcastChannel constructor without 'new' must throw"
+    );
+}, "BroadcastChannel constructor called as normal function");
+
 async_test(t => {
     let c1 = new BroadcastChannel('eventType');
     let c2 = new BroadcastChannel('eventType');
diff --git a/test/fixtures/wpt/webmessaging/broadcastchannel/workers.html b/test/fixtures/wpt/webmessaging/broadcastchannel/workers.html
@@ -256,7 +256,7 @@
       // Since the worker has closed, it's not expected that the
       // BroadcastChannel will receive messages (there's a separate test for
       // that), so just indicate directly that it's ready to test receiving
-      // a message from the parent despite the possibility of a race condition.
+      // a message from the parent dispite the possibility of a race condition.
       postMessage('ready');
     }
   });

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+features:`
	`2`	`+- name: broadcast-channel`
	`3`	`+ files: "**"`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@`
`256`	`256`	`// Since the worker has closed, it's not expected that the`
`257`	`257`	`// BroadcastChannel will receive messages (there's a separate test for`
`258`	`258`	`// that), so just indicate directly that it's ready to test receiving`
`259`		`- // a message from the parent despite the possibility of a race condition.`
	`259`	`+ // a message from the parent dispite the possibility of a race condition.`
`260`	`260`	`postMessage('ready');`
`261`	`261`	`}`
`262`	`262`	`});`