src,permission: enhance permission model debug

RafaelGSS · aduh95 · commit 72f75bb976af · 2025-07-24T20:08:32.000+02:00
This commit enhance the permission model debug logs when NODE_DEBUG_NATIVE=PERMISSION_MODEL is used Example Inserting /Users/rafaelgss/repos/os/node/t.js └─ / ├─ Users/rafaelgss/repos/os/node/t.js └─ tm ├─ 3 ├─ 2 └─ p/* Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #58898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -72,43 +72,53 @@ bool is_tree_granted(
   return granted_tree->Lookup(resolved_param, true);
 }
 
-void PrintTree(const node::permission::FSPermission::RadixTree::Node* node,
-               size_t spaces = 0) {
-  std::string whitespace(spaces, ' ');
+static const char* kBoxDrawingsLightUpAndRight = "&#9492;&#9472; ";
+static const char* kBoxDrawingsLightVerticalAndRight = "&#9500;&#9472; ";
 
+void PrintTree(const node::permission::FSPermission::RadixTree::Node* node,
+               size_t depth = 0,
+               const std::string& branch_prefix = "",
+               bool is_last = true) {
   if (node == nullptr) {
     return;
   }
-  if (node->wildcard_child != nullptr) {
-    node::per_process::Debug(node::DebugCategory::PERMISSION_MODEL,
-                             "%s Wildcard: %s\n",
-                             whitespace,
-                             node->prefix);
-  } else {
+
+  if (depth > 0 || (node->prefix.length() > 0)) {
+    std::string indent;
+
+    if (depth > 0) {
+      indent = branch_prefix;
+      if (is_last) {
+        indent += kBoxDrawingsLightUpAndRight;
+      } else {
+        indent += kBoxDrawingsLightVerticalAndRight;
+      }
+    }
+
     node::per_process::Debug(node::DebugCategory::PERMISSION_MODEL,
-                             "%s Prefix: %s\n",
-                             whitespace,
-                             node->prefix);
-    if (node->children.size()) {
-      size_t child = 0;
-      for (const auto& pair : node->children) {
-        ++child;
-        node::per_process::Debug(node::DebugCategory::PERMISSION_MODEL,
-                                 "%s Child(%s): %s\n",
-                                 whitespace,
-                                 child,
-                                 std::string(1, pair.first));
-        PrintTree(pair.second, spaces + 2);
+                             "%s%s\n",
+                             indent.c_str(),
+                             node->prefix.c_str());
+  }
+
+  if (node->children.size() > 0) {
+    size_t count = 0;
+    size_t total = node->children.size();
+
+    std::string next_branch_prefix;
+    if (depth > 0) {
+      next_branch_prefix = branch_prefix;
+      if (is_last) {
+        next_branch_prefix += "   ";
+      } else {
+        next_branch_prefix += "&#9474;  ";
       }
-      node::per_process::Debug(node::DebugCategory::PERMISSION_MODEL,
-                               "%s End of tree - child(%s)\n",
-                               whitespace,
-                               child);
-    } else {
-      node::per_process::Debug(node::DebugCategory::PERMISSION_MODEL,
-                               "%s End of tree: %s\n",
-                               whitespace,
-                               node->prefix);
+    }
+
+    for (const auto& pair : node->children) {
+      count++;
+      bool child_is_last = (count == total);
+      PrintTree(pair.second, depth + 1, next_branch_prefix, child_is_last);
     }
   }
 }
