src: remove SecureContext::operator*

tniessen · bengl · commit 72a767b7cab2 · 2022-05-30T12:26:50.000-04:00
This rather mysterious operator is only used once and can easily be replaced with ssl_ctx(). PR-URL: #43121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -213,7 +213,7 @@ const char* GetServerName(SSL* ssl) {
 }
 
 bool SetGroups(SecureContext* sc, const char* groups) {
-  return SSL_CTX_set1_groups_list(**sc, groups) == 1;
+  return SSL_CTX_set1_groups_list(sc->ssl_ctx(), groups) == 1;
 }
 
 const char* X509ErrorCode(long err) {  // NOLINT(runtime/int)
diff --git a/src/crypto/crypto_context.h b/src/crypto/crypto_context.h
@@ -41,8 +41,6 @@ class SecureContext final : public BaseObject {
   static void RegisterExternalReferences(ExternalReferenceRegistry* registry);
   static SecureContext* Create(Environment* env);
 
-  SSL_CTX* operator*() const { return ctx_.get(); }
-
   SSL_CTX* ssl_ctx() const { return ctx_.get(); }
 
   SSLPointer CreateSSL();

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ const char* GetServerName(SSL* ssl) {`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`bool SetGroups(SecureContext* sc, const char* groups) {`
`216`		`- return SSL_CTX_set1_groups_list(**sc, groups) == 1;`
	`216`	`+ return SSL_CTX_set1_groups_list(sc->ssl_ctx(), groups) == 1;`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`const char* X509ErrorCode(long err) { // NOLINT(runtime/int)`